[PATCH] D54847: [MachineScheduler] Add support for clustering mem ops with FI base operands

Nirav Dave via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 27 11:00:49 PST 2018


niravd accepted this revision.
niravd added a comment.
This revision is now accepted and ready to land.

LGTM modulo a small nit I missed on the last pass.



================
Comment at: lib/CodeGen/MachineScheduler.cpp:1500
+                               RHS.SU->NodeNum);
+      else if (BaseOp->isFI())
+        return std::make_tuple(BaseOp->getIndex(), Offset, SU->NodeNum) <
----------------
nit: Remove this else as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54847/new/

https://reviews.llvm.org/D54847





More information about the llvm-commits mailing list