[PATCH] D54936: [llvm-objcopy] Hook up the -V alias to --version, output "GNU strip"

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo marked an inline comment as done.
mstorsjo added a comment.

In D54936#1309342 <https://reviews.llvm.org/D54936#1309342>, @jhenderson wrote:

> Should we do the same thing (adding "comptabile with GNU objcopy") for llvm-objcopy as well as llvm-strip?


I don't know of any build system that checks for that in the output, but I guess we could do that for consistency.



================
Comment at: test/tools/llvm-objcopy/strip-version.test:5
 
-# CHECK: {{ version }}
+# CHECK: GNU strip
----------------
jhenderson wrote:
> This should probably check both {{version}} and "GNU strip", right?
Right, I can keep that check as well. Will update the patch in a few hours.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54936/new/

https://reviews.llvm.org/D54936