[PATCH] D54873: [WebAssembly] Make signature index not a part of EventType

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 25 00:39:08 PST 2018


aheejin created this revision.
aheejin added reviewers: dschuff, sbc100.
Herald added subscribers: llvm-commits, arphaman, sunfish, jgravelle-google.

Previously `EventType` contained `SigIndex` as its member based on the
spec, but signature indieces can change after linking, which makes
`EventType` not a constant property of an event. This patch takes
`SigIndex` out of `EventType` and treat it similarly with function
types and makes `SigIndex` a property that any type can optionally
possess.

This is not a spec change; this only affects yaml tests and
binary file results do not change after this patch.


Repository:
  rL LLVM

https://reviews.llvm.org/D54873

Files:
  include/llvm/BinaryFormat/Wasm.h
  include/llvm/Object/Wasm.h
  include/llvm/ObjectYAML/WasmYAML.h
  lib/MC/WasmObjectWriter.cpp
  lib/Object/WasmObjectFile.cpp
  lib/ObjectYAML/WasmYAML.cpp
  lib/Target/WebAssembly/WebAssemblyMCInstLower.cpp
  test/MC/WebAssembly/event-section.ll
  test/ObjectYAML/wasm/event_section.yaml
  tools/obj2yaml/wasm2yaml.cpp
  tools/yaml2obj/yaml2wasm.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54873.175170.patch
Type: text/x-patch
Size: 15731 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181125/333d333a/attachment.bin>


More information about the llvm-commits mailing list