[PATCH] D54517: [CGP] Limit Complex Addressing mode by number of BasicBlocks to traverse

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 22 14:07:58 PST 2018


bjope added reviewers: chandlerc, haicheng.
bjope added subscribers: haicheng, chandlerc.
bjope added a comment.

I don't have any objections to the patch myself, but I don't really have the knowledge to understand if this could be bad for some important use cases either. A user can ofcourse override the threshold if needed, so I guess that makes this patch a little bit less "dangerous".

It looks like @chandlerc and @haicheng has contributed to this pass in the past. Can perhaps one of you help out and take a quick look at this to see if introducing this threshold is a reasonable fix?


https://reviews.llvm.org/D54517





More information about the llvm-commits mailing list