[PATCH] D53342: [SimplifyLibCalls] Mark known arguments with nonnull

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 22 07:26:00 PST 2018


xbolva00 added a comment.

In https://reviews.llvm.org/D53342#1306284, @hfinkel wrote:

> In https://reviews.llvm.org/D53342#1306028, @xbolva00 wrote:
>
> > I have no idea how to fix Clang side :/
>
>
> Okay. Does that need to happen as a prerequisite to this patch?


Not directly for this one, but we need it for the final goal (enable nonnull arg promotion in FunctionAttrs) so ISCCP or other passes can be more powerful.
If we fix it on Clang side, this patch would be smaller (without dropping nonnull attr)

Another thing we need to solve is a “call sinking” (if enabled, ISCCP misses many opportunities to remove null checks)

And we would be even more powerful with FunctionAttrs as a Module pass  to use DT in arg attribute promotion logic (now we do it only for entry block).


https://reviews.llvm.org/D53342





More information about the llvm-commits mailing list