[PATCH] D54472: Disable invalid isPodLike<> specialization

[serge via Phabricator via llvm-commits]

serge-sans-paille added inline comments.


================
Comment at: include/llvm/ADT/Optional.h:134
+  void reset() { hasVal = false; }
+};
+
----------------
efriedma wrote:
> This looks almost identical to the specialization we had before r347004; does this avoid the miscompiles somehow?
I double checked this commit, and yes it is important because the generic implementation is not trivially copyable: it has a non default destructor. Knowing that T is trivially copyable makes it possible to have a trivial destructor.


https://reviews.llvm.org/D54472