[PATCH] D54555: [clang][slh] add attribute for speculative load hardening

Kristof Beyls via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 22 00:00:52 PST 2018


kristof.beyls accepted this revision.
kristof.beyls added a comment.

LGTM now. I'm not an expert on the clang attribute mechanics, so am relying on Aaron's judgement/review for that part.
Thanks Zola!

I noticed that the documentation for the LLVM-IR speculative_load_hardening attribute in LangRef (section https://llvm.org/docs/LangRef.html#function-attributes) will now no longer be the same as the documentation for the clang attribute here after reviewing. Maybe it'd be best to update that documentation to be the same as the one for the clang attribute here?


Repository:
  rL LLVM

https://reviews.llvm.org/D54555





More information about the llvm-commits mailing list