[PATCH] D54546: [ARM] Don't expand sdiv when optimising for minsize

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 21 07:00:43 PST 2018


RKSimon added inline comments.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:7812
+  const SDValue &V1 = N->getOperand(1);
+  assert(dyn_cast<ConstantSDNode>(V1));
+
----------------
Why do you need this? BuildSDIVPow2 is only called with constant (pow2) divisors, also it'll fail for constant vectors.


https://reviews.llvm.org/D54546





More information about the llvm-commits mailing list