[PATCH] D54543: [stack-safety] Inter-Procedural Analysis implementation

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:380
+  SetVector<const GlobalValue *> WorkList;
+  DenseMap<const GlobalValue *, int> UpdateCount;
+
----------------
UpdateCount could be moved to FunctionInfo to save a hash map lookup.



================
Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:421
+  if (IT == Functions.end())
+    return ConstantRange(64);
+  const StackSafetyInfo::FunctionInfo &FS = IT->second;
----------------
Use DataLayout::getPointerSizeInBits instead of 64.



================
Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:514
+  runDataFlow();
+  LLVM_DEBUG(verifyFixedPoint());
+
----------------
This makes verifyFixedPoint unused in no-assertions build. Move it under LLVM_DEBUG, too.


Repository:
  rL LLVM

https://reviews.llvm.org/D54543