[PATCH] D54593: [X86] Fix PR39658: avoid duplicated successors in condibr merge

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 20 16:37:29 PST 2018


xbolva00 added inline comments.


================
Comment at: lib/Target/X86/X86CondBrFolding.cpp:275
+  BranchProbability Prob = MBPI->getEdgeProbability(MBB, OrigDest);
+  if (SI == MBB->succ_end()) {
+    MBB->addSuccessor(NewDest);
----------------
Remove brackets?


================
Comment at: lib/Target/X86/X86CondBrFolding.cpp:377
     fixPHIsInSucc(TargetMBB, &MBB, RootMBB);
+
     RootMBB->erase(UncondBrI);
----------------
Extra newline


https://reviews.llvm.org/D54593





More information about the llvm-commits mailing list