[PATCH] D52060: AMDGPU: Add a fast path for icmp.i1(src, false, NE)

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 20 16:01:01 PST 2018


arsenm added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:3656-3658
+        // Don't do anything for i1 comparisons.
+        if (Width == 1)
+          break;
----------------
mareko wrote:
> arsenm wrote:
> > Needs test in InstCombine
> What should the test do?
use an original i1 eq/ne comparison. Like the others, just i1


Repository:
  rL LLVM

https://reviews.llvm.org/D52060





More information about the llvm-commits mailing list