[PATCH] D54739: [Sanitizer] intercept setvbuf on other platforms where it is supported

David CARLIER via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 20 14:07:49 PST 2018


devnexen added inline comments.


================
Comment at: test/sanitizer_common/TestCases/Posix/setvbuf.cc:19
 
   setbuf(stdout, buf);
 
----------------
vitalybuka wrote:
> hm, we do not intercept this one, and two below
Seemed a near future plan though but I can always delete them if really wished ?


================
Comment at: test/sanitizer_common/TestCases/Posix/setvbuf.cc:37
 void test_setlinebuf() {
   char buf[BUFSIZ];
 
----------------
vitalybuka wrote:
> buf[BUFSIZ] is unused
True


https://reviews.llvm.org/D54739





More information about the llvm-commits mailing list