[PATCH] D53461: [X86][compiler-rt] Add additional CPUs and features to the cpu detection to match libgcc

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 20 11:18:22 PST 2018


lebedev.ri added inline comments.


================
Comment at: compiler-rt/trunk/lib/builtins/cpu_model.c:467-468
+  do {                             \
+    if (F < 32)                    \
+      Features |= 1 << F;          \
+    else if (F < 64)               \
----------------
F = 31
F < 32
1 << 31
2147483648
which is just the sign bit set

This should probably be
```
Features |= 1U << F;
```


Repository:
  rL LLVM

https://reviews.llvm.org/D53461





More information about the llvm-commits mailing list