[PATCH] D54714: [AMDGPU] Add and update scalar instructions

[Graham Sellers via Phabricator via llvm-commits]

grahamsellers marked an inline comment as done.
grahamsellers added inline comments.


================
Comment at: lib/Target/AMDGPU/SIInstrInfo.cpp:4538-4539
+    MachineInstr *Xor = nullptr;
+    unsigned Temp = MRI.createVirtualRegister(&AMDGPU::SGPR_32RegClass);
+    unsigned NewDest = MRI.createVirtualRegister(&AMDGPU::SGPR_32RegClass);
+
----------------
arsenm wrote:
> Should probably use SReg_32_XEXEC
I couldn't find a SReg_32_XEXEC class, only SReg_32_XEXEC_HI, which seems to only exclude EXEC_LO, or SReg_64_XEXEC, which is 64-bit. Is there any particular reason to avoid EXEC? I can't get the compiler to hit that anyway.


https://reviews.llvm.org/D54714