[PATCH] D53927: [AArch64] Enable libm vectorized functions via SLEEF

[Francesco Petrogalli via Phabricator via llvm-commits]

fpetrogalli added a comment.

@joel_k_jones , @steleman

I am sorry for having kept you waiting for the patch. I was not fully aware of the approval process upstream (didn’t do much contributions upstream myself), and before being able to approve I had to understand the process.

I will approve the patch and you will be able to submit it, but before doing that I would like to ask another tiny change.

I would like to change the value of the option from -fveclib=SLEEFGNUABI to -fveclib=SLEEFGNUABI10. The rest of the patch can stay the same.

By specifying “10” at the end of the option value, it will be clear to the user that they are using high precision functions. In the future, we might add the 3.5 ULP ones with the option SLEEFGNUABI35.

Thank you for promoting SLEEF in clang!

I hope this makes sense.

Francesco


https://reviews.llvm.org/D53927