[PATCH] D54695: [PM] Port Scalarizer to the new pass manager.

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 20 07:23:13 PST 2018


fedor.sergeev accepted this revision.
fedor.sergeev added a comment.
This revision is now accepted and ready to land.

LGTM, but feel free to address Chandlers' note if you dont have strong feelings against it.



================
Comment at: lib/Transforms/Scalar/Scalarizer.cpp:169
 
-  bool doInitialization(Module &M) override;
-  bool runOnFunction(Function &F) override;
+  bool transform(Function &F);
 
----------------
Chandler suggestion was to rename this method to 'visit'.
I dont have strong preference here, though his reasoning about shadowing InstVisitor's methods sorta makes sense.


https://reviews.llvm.org/D54695





More information about the llvm-commits mailing list