[PATCH] D54742: [CodeMetrics] Don't let extends of i1 be free.

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 20 03:40:41 PST 2018


jonpa updated this revision to Diff 174745.
jonpa marked an inline comment as done.
jonpa added a comment.

> As was mentioned in the original patch, this does still need tests. There are tests here, for example in `test/Analysis/CostModel/...`. You should be able to see som\

e differences in costs, especially for architectures where the resulting cost computation differs significantly.

Putting back my test case hoping it will serve the purpose

Please also see inline comments.


https://reviews.llvm.org/D54742

Files:
  include/llvm/Analysis/TargetTransformInfoImpl.h
  test/Analysis/CostModel/SystemZ/getUserCost_ext_i1.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54742.174745.patch
Type: text/x-patch
Size: 3910 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181120/0b2e2fe8/attachment.bin>


More information about the llvm-commits mailing list