[PATCH] D54733: [ASan] Make asan report decoration more efficient

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_descriptions.h:40
+    last_byte = 0;
+  }
+  const char *Reset() {
----------------
what was changed here?
Did you use arc tool?


================
Comment at: compiler-rt/lib/asan/asan_descriptions.h:49
   const char *ShadowByte(u8 byte) {
+    // Optimization: Don't return color string unless the color changes.
+    if (last_byte == byte)
----------------
lets keep same name
  const char *Default() {
    last_byte = 0;
    return __sanitizer::SanitizerCommonDecorator::Default();
  }


================
Comment at: compiler-rt/lib/asan/asan_descriptions.h:96
                                           "high shadow"};

 struct ShadowAddressDescription {
   uptr addr;
----------------
u8 last_byte = 0;


================
Comment at: compiler-rt/lib/asan/asan_descriptions.h:96
                                           "high shadow"};

 struct ShadowAddressDescription {
   uptr addr;
----------------
vitalybuka wrote:
> u8 last_byte = 0;
maybe instead of last byte just track "const char * last_decoration"?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D54733