[PATCH] D54719: [Intrinsic] Signed Fixed Point Multiplication Intrinsic

[Leonard Chan via Phabricator via llvm-commits]

leonardchan added a comment.

In https://reviews.llvm.org/D54719#1303553, @craig.topper wrote:

> Need to update LangRef.rst which I think we also missed for the saturating intrinsics.


Funny, I actually just uploaded a patch for the LangRef docs on the other intrinsics (https://reviews.llvm.org/D54729). Also added the docs for this intrinsic in this patch.



================
Comment at: llvm/include/llvm/CodeGen/ISDOpcodes.h:278
+    /// both operands as fixed point numbers. A scale of zero is effectively
+    /// performing saturation multiplication on 2 integers.
+    SMULFIX,
----------------
craig.topper wrote:
> This is says it saturates but I didn't see that implemented in the expansion function.
My bad, this intrinsic doesn't perform saturation.


Repository:
  rL LLVM

https://reviews.llvm.org/D54719