[PATCH] D54548: Add interceptor for the setvbuf(3) from NetBSD

[David CARLIER via Phabricator via llvm-commits]

devnexen added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_platform_interceptors.h:519
 #define SANITIZER_INTERCEPT_NETENT SI_NETBSD
+#define SANITIZER_INTERCEPT_SETVBUF SI_NETBSD
 
----------------
krytarowski wrote:
> vitalybuka wrote:
> > devnexen wrote:
> > > krytarowski wrote:
> > > > vitalybuka wrote:
> > > > > This is not NETBSD specific?
> > > > It originated in BSD, went into SunOS, and from there to C89 or similar.. but I cannot test it on other OSes. Please enable and test it on them in a separate commit.
> > > Would it be possible to put the test in the posix folder ? Would enable the feature on FreeBSD later on.
> > up to you. you can move it now with XFAIL, or  move later
> Committed!
> 
> Sorry for inappropriate place, but when I've included an interceptor for devname_r(3), it was enabled for !NetBSD.. however there is wrong prototype for !NetBSD. NetBSD uses `int` as a return value, others use `char*`.
> 
> @devnexen could we drop SI_OPENBSD from this file, it's not used and probably won't be used.
I hesitate doing so ... Someone contacted me he would try to find a way to port asan on openbsd and thought I would drop this for good after a while (beginning next year) if I see no sign ...


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D54548