[PATCH] D54548: Add interceptor for the setvbuf(3) from NetBSD

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 19 14:44:22 PST 2018


vitalybuka added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_platform_interceptors.h:519
 #define SANITIZER_INTERCEPT_NETENT SI_NETBSD
+#define SANITIZER_INTERCEPT_SETVBUF SI_NETBSD
 
----------------
devnexen wrote:
> krytarowski wrote:
> > vitalybuka wrote:
> > > This is not NETBSD specific?
> > It originated in BSD, went into SunOS, and from there to C89 or similar.. but I cannot test it on other OSes. Please enable and test it on them in a separate commit.
> Would it be possible to put the test in the posix folder ? Would enable the feature on FreeBSD later on.
up to you. you can move it now with XFAIL, or  move later


Repository:
  rL LLVM

https://reviews.llvm.org/D54548





More information about the llvm-commits mailing list