[PATCH] D54688: [WebAssembly] Fix inaccurate comments / assertion messages

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 19 12:31:28 PST 2018


sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: wasm/Symbols.h:339
                 "Symbol types must be trivially destructible");
-  static_assert(sizeof(T) <= sizeof(SymbolUnion), "Symbol too small");
+  static_assert(sizeof(T) <= sizeof(SymbolUnion), "Symbol too large");
   static_assert(alignof(T) <= alignof(SymbolUnion),
----------------
This a copied from ELF/Symbols.h.  Lokos like it should be "SymbolUnion too small".


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D54688





More information about the llvm-commits mailing list