[PATCH] D54594: Add new interceptors for vis(3) API in NetBSD

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7285
+    COMMON_INTERCEPTOR_WRITE_RANGE(
+        ctx, dst, (SIZE_T)(end - dst + 1) < dlen ? end - dst + 1 : dlen);
+  return end;
----------------
Min()


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7318
+  // The interface will be valid even if there is no space for NULL char
+  if (dst && len >= 0)
+    COMMON_INTERCEPTOR_WRITE_RANGE(ctx, dst,
----------------
len >= 0 is always true, it's unsigned type



================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7320
+    COMMON_INTERCEPTOR_WRITE_RANGE(ctx, dst,
+                                   (SIZE_T)len + 1 < dlen ? len + 1 : dlen);
+  return len;
----------------
Min and few below


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7523
+  COMMON_INTERCEPT_FUNCTION(strvisx);                                          \
+  COMMON_INTERCEPT_FUNCTION(strnvisx);                                         \
+  COMMON_INTERCEPT_FUNCTION(strenvisx);                                        \
----------------
they are so similar, is any idea how to minimize code size?


Repository:
  rL LLVM

https://reviews.llvm.org/D54594