[PATCH] D48826: [AMDGPU] Add support for TFE/LWE in image intrinsics

David Stuttard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 19 07:35:42 PST 2018


dstuttard added inline comments.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:4711-4713
+    DAG.ExtractVectorElements(CastRes, Elts, 0, DMaskPop);
+    for (SDValue &Elt : Elts) {
+      BVElts.push_back(Elt);
----------------
nhaehnle wrote:
> I think you can directly ExtractVectorElements into `BVElts` and get rid of `Elts` entirely.
Doh.


Repository:
  rL LLVM

https://reviews.llvm.org/D48826





More information about the llvm-commits mailing list