[PATCH] D54614: [WebAssembly] Fix MCNullStreamer support

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: test/CodeGen/WebAssembly/null-streamer.ll:11
+define i32 @f(i8* %p)  {
+  call void @llvm.wasm.throw(i32 0, i8* %p)
+  call void @g()
----------------
eush wrote:
> aheejin wrote:
> > sbc100 wrote:
> > > eush wrote:
> > > > sbc100 wrote:
> > > > > Can you simplify this test, drop the trow and remove the exception arguments from llc?
> > > > Can I wonder why? A simpler test would only exercise changes in EmitFunctionBodyStart and wouldn't need any changes in EmitEndOfAsmFile.
> > > Oh I see.   I just found a it a little strange to have those options enabled, but I suppose it makes sense.  Alternatively you could call alloca in order to trigger the use of __stack_pointer.
> > > 
> > > Also, if you want to be sure you excersise those parts maybe you would want to at a CHECK: for the .globaltype and/or .eventtype at the end?
> > This is nullstreamer, so I guess it wouldn't print anything so we can't check.
> > This is nullstreamer, so I guess it wouldn't print anything so we can't check.
> 
> That is unless we add a second RUN line with a default streamer, just for the checks.
This might be a better idea, having a second RUN line. I'll fix that in D54660,


Repository:
  rL LLVM

https://reviews.llvm.org/D54614