[PATCH] D54656: [hwasan] implement free_checks_tail_magic=1

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: lib/hwasan/hwasan_allocator.cc:46
+// Initialized in HwasanAllocatorInit, an never changed.
+static ALIGNED(16) u8 tail_magic[kShadowAlignment];
 
----------------
I don't think ALIGNED(16) is necessary.


================
Comment at: lib/hwasan/hwasan_allocator.cc:222
+    uptr tail_size = tagged_size - orig_size;
+    CHECK_LT(tail_size, kShadowAlignment);
+    void *tail_beg = reinterpret_cast<void *>(
----------------
less-or-equals
When size is 0, tagged_size is 16.


Repository:
  rL LLVM

https://reviews.llvm.org/D54656