[PATCH] D54652: [WebAssembly] replaced .param/.result by .functype

Wouter van Oortmerssen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 16 15:13:40 PST 2018


aardappel marked an inline comment as done.
aardappel added inline comments.


================
Comment at: lib/MC/MCParser/AsmLexer.cpp:653
+    }
+    return AsmToken(AsmToken::Minus, StringRef(TokStart, 1));
   case '|':
----------------
sbc100 wrote:
> Is there a risk we could break other asm backends with this?
If there's other backend that allow parsing a `-` token followed by `>` token with no whitespace in between, then we will break them, yes. I think this is highly unlikely, as I don't know of any kind of expression where that could occur.


Repository:
  rL LLVM

https://reviews.llvm.org/D54652





More information about the llvm-commits mailing list