[PATCH] D54581: [compiler-rt] Windows Debug build fix

[Matthew G McGovern via Phabricator via llvm-commits]

mcgov added a comment.

In https://reviews.llvm.org/D54581#1300511, @vitalybuka wrote:

> >> And I don't see this code in the r346999
>
> Could you please explain why you need to patch code which is not in the repo?


Not sure what you mean, this patch fixes debug builds on Windows. The issue is that there is no code to define that symbol currently. Building debug will not succeed because of the undefined symbol, MemalignFromLocalPool. The idea was to define the symbol as nullptr, since the code path is never executed on Windows and is optimized away in Release builds. It occurs to me that a function that just asserts if it's called may be a better idea , rather than the dumb macro.

Ah I think I see the issue. I uploaded a diff from my first version of the patch, rather than a clean diff from the master version. I'll fix this now.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D54581