[PATCH] D54635: [ThinLTO] Consolidate cache key computation between new/old LTO APIs

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

In https://reviews.llvm.org/D54635#1301384, @steven_wu wrote:

> I wonder freestanding is still an issue after r316819. There is a function attribute for that now so it should be respected if the module is built with -ffreestanding and it should create different hash. I will do some digging to see if I can find the original report and how they setup the build. @mehdi_amini, do you remember the original problem?


There is some background on the bug (https://bugs.llvm.org/show_bug.cgi?id=30403). Per comment 2, the problem was a different issue than what is solved by the function attribute (I checked, the application of the nobuiltin attribute predates https://reviews.llvm.org/D30791). But since there should be a function attribute applied, that presumably would affect the hash as you noted. Hopefully @pcc can comment as he did some investigation on the original bug.

> I also need to do a bit more thinking on the preserve symbol. I think the new LTO API went a completely different route from the old API.




Repository:
  rL LLVM

https://reviews.llvm.org/D54635