[PATCH] D54624: [LLD][ELF] Error if _GLOBAL_OFFSET_TABLE_ is defined in input objects

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

Change looks reasonable. Have a suggestion about the code though.



================
Comment at: ELF/Writer.cpp:222
+      Out::ElfHeader, Target->GotBaseSymOff, STV_HIDDEN, STB_GLOBAL,
+      /*AllowMulDef*/ false);
 
----------------
Maybe just inline the code here?

```
  StringRef GotTableSymName =
      (Config->EMachine == EM_PPC64) ? ".TOC." : "_GLOBAL_OFFSET_TABLE_";
  if (Symtab->find(GotTableSymName))
    ElfSym::GlobalOffsetTable = cast<Defined>(
        Symtab->addDefined(GotTableSymName, Out::ElfHeader,
                           Target->GotBaseSymOff, STV_HIDDEN, STB_GLOBAL));
```


https://reviews.llvm.org/D54624