[PATCH] D54555: [clang][slh] add attribute for speculative load hardening

[Zola Bridges via Phabricator via llvm-commits]

zbrid marked an inline comment as done.
zbrid added inline comments.


================
Comment at: clang/test/CodeGen/attr-speculative-load-hardening.cpp:1-2
+// RUN: %clang_cc1 -std=c++11 -disable-llvm-passes -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK1
+// RUN: %clang_cc1 -std=c++11 -disable-llvm-passes -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK2
+//
----------------
chandlerc wrote:
> A question I have is how this interacts with the commandline flag?
> 
> Or are you thinking to handle that separately in a follow-up patch?
> 
> I'm pretty happy with either approach, mostly curious.
I'll address and test the interaction between this attribute and the command line flag in a follow up patch. The current plan is to 1) add an attribute to not harden a function 2) warn the user if they marked a function to not be hardened that may be hardened due to the behavior where a calling function gets hardened if a called function is hardened and inlined into the calling function 3) have the command line flag set the default and the function attribute to override the default.


Repository:
  rL LLVM

https://reviews.llvm.org/D54555