[PATCH] D48179: [AMDGPU] Emit MessagePack HSA Metadata for v3 code object

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 15 12:46:59 PST 2018


kzhuravl added a comment.

what is the rationale for putting the metadata verifier in binary format instead of support?



================
Comment at: lib/Target/AMDGPU/AMDGPUAsmPrinter.h:59
 
-  AMDGPU::HSAMD::MetadataStreamer HSAMetadataStream;
+  AMDGPU::HSAMD::MetadataStreamer *HSAMetadataStream;
   std::map<uint32_t, uint32_t> PALMetadataMap;
----------------
unique_ptr?


https://reviews.llvm.org/D48179





More information about the llvm-commits mailing list