[PATCH] D54514: [llvm-exegesis] InstructionBenchmarkClustering::dbScan(): use manual std::deque<size_t> + std::vector<char> instead of SetVector.

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In https://reviews.llvm.org/D54514#1298649, @MaskRay wrote:

> ... but I think `Set` should not be reset to 0 as elements can be pushed while they are neither Noise nor Undef, and that is wasteful.


I'm absolutely sure there is more headroom here.
I won't touch that in this patchseries though, as i'm already worried that there are too many patches
and it won't be reviewed (which kind-of stalls my further potential bdver2 improvements.)

> I still hope my https://reviews.llvm.org/D54442 can be reviewed (but I'll not do anything else to interfere with your other optimization :)

That "don't remove from set" part looks interesting, so if this patchseries goes in first, you could rebase https://reviews.llvm.org/D54442 to contain only that opt :)


Repository:
  rL LLVM

https://reviews.llvm.org/D54514