[PATCH] D54571: [WebAssembly] Split BBs after throw instructions

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 15 11:06:34 PST 2018


tlively added a comment.

In https://reviews.llvm.org/D54571#1300167, @sbc100 wrote:

> In https://reviews.llvm.org/D54571#1299575, @xbolva00 wrote:
>
> > Sorry for little offtopic at first.
> >
> > WebAssembly folks, can you check this warning:
> >
> > WebAssemblyDisassembler.cpp:125:11: warning: comparison is always false due to limited range of data type [-Wtype-limits]
> >
> >   if (Opc < 0)
> >   
> >
> > GCC 8.2
>
>
> Hmm, looks like that broke in https://reviews.llvm.org/D54138.  @tlively ?


This should be fixed in https://reviews.llvm.org/rL346979.


Repository:
  rL LLVM

https://reviews.llvm.org/D54571





More information about the llvm-commits mailing list