[PATCH] D54586: [WebAssembly] Fix return type of nextByte

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 15 11:00:35 PST 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rL346979: [WebAssembly] Fix return type of nextByte (authored by tlively, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D54586?vs=174227&id=174251#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D54586

Files:
  llvm/trunk/lib/Target/WebAssembly/Disassembler/WebAssemblyDisassembler.cpp


Index: llvm/trunk/lib/Target/WebAssembly/Disassembler/WebAssemblyDisassembler.cpp
===================================================================
--- llvm/trunk/lib/Target/WebAssembly/Disassembler/WebAssemblyDisassembler.cpp
+++ llvm/trunk/lib/Target/WebAssembly/Disassembler/WebAssemblyDisassembler.cpp
@@ -68,7 +68,7 @@
                                          createWebAssemblyDisassembler);
 }
 
-static uint8_t nextByte(ArrayRef<uint8_t> Bytes, uint64_t &Size) {
+static int nextByte(ArrayRef<uint8_t> Bytes, uint64_t &Size) {
   if (Size >= Bytes.size())
     return -1;
   auto V = Bytes[Size];
@@ -121,7 +121,7 @@
     raw_ostream & /*OS*/, raw_ostream &CS) const {
   CommentStream = &CS;
   Size = 0;
-  auto Opc = nextByte(Bytes, Size);
+  int Opc = nextByte(Bytes, Size);
   if (Opc < 0)
     return MCDisassembler::Fail;
   const auto *WasmInst = &InstructionTable0[Opc];


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54586.174251.patch
Type: text/x-patch
Size: 890 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181115/d83cd9ba/attachment.bin>


More information about the llvm-commits mailing list