[PATCH] D53444: Support ARM_V4BX relocation

[Yin Ma via Phabricator via llvm-commits]

yinma added inline comments.


================
Comment at: test/ELF/v4bx.yaml:4-6
+# RUN: llvm-readelf -sections %t.out | FileCheck %s
+
+# CHECK: .text
----------------
ruiu wrote:
> Does this really check anything? My understanding is that if `ld.lld` succeeds, then the test succeeded. So you don't really need readelf, no?
We cannot assume ld.lld succeeds without checking the output. Without readelf checking, if lld just simply returns 0 without producing a correct .o, the test will still pass. Actually it is good practice to check something in the output for all unit tests. 


https://reviews.llvm.org/D53444