[PATCH] D54564: [LTO] Load sample profile in LTO link step.

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 15 09:53:45 PST 2018


tejohnson added inline comments.


================
Comment at: lib/Passes/PassBuilder.cpp:1008
+                                        PGOOpt->ProfileRemappingFile,
+                                        false /* ThinLTOPhase::PreLink */));
+  }
----------------
trentxintong wrote:
> tejohnson wrote:
> > Nit: I think the typical format is to put the parameter name comment before the constant.
> A few lines up, line 976 in this file says different -:).
Ok nevermind then, better to be consistent within this file.


Repository:
  rL LLVM

https://reviews.llvm.org/D54564





More information about the llvm-commits mailing list