[PATCH] D54564: [LTO] Load sample profile in LTO link step.

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 15 09:34:19 PST 2018


tejohnson added inline comments.


================
Comment at: lib/Passes/PassBuilder.cpp:1008
+                                        PGOOpt->ProfileRemappingFile,
+                                        false /* ThinLTOPhase::PreLink */));
+  }
----------------
Nit: I think the typical format is to put the parameter name comment before the constant.


================
Comment at: test/LTO/Resolution/X86/load-sample-prof-lto.ll:19
+;
+; NEW-PM-SAMPLE: !prof
+
----------------
No need to use different check prefixes for the two pass managers since they are checking the same thing.


Repository:
  rL LLVM

https://reviews.llvm.org/D54564





More information about the llvm-commits mailing list