[PATCH] D54581: [compiler-rt] Windows Debug build fix

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 15 07:56:50 PST 2018


zturner added inline comments.


================
Comment at: lib/asan/asan_new_delete.cc:73
+#ifdef SANITIZER_WINDOWS && DEBUG
+ #define MemalignFromLocalPool(x,y) nullptr
+#endif
----------------
I don't have an opinion on whether this fix is ok, but is the `#ifdef` correct here?  Shouldn't it be `#if defined(SANITIZER_WINDOWS) && defined(DEBUG)` or `#if SANITIZER_WINDOWS && DEBUG`


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D54581





More information about the llvm-commits mailing list