[PATCH] D54575: [llvm-objdump] Replace cast<> by dyn_cast<>

[Xing via Phabricator via llvm-commits]

Higuoxing created this revision.
Higuoxing added reviewers: jhenderson, MaskRay.
Herald added a subscriber: llvm-commits.

`cast<>` can cause assertion failure, so the `else routine` is unreachable.


Repository:
  rL LLVM

https://reviews.llvm.org/D54575

Files:
  tools/llvm-objdump/llvm-objdump.cpp


Index: tools/llvm-objdump/llvm-objdump.cpp
===================================================================
--- tools/llvm-objdump/llvm-objdump.cpp
+++ tools/llvm-objdump/llvm-objdump.cpp
@@ -1243,7 +1243,7 @@
     addDynamicElfSymbols(Elf64LEObj, AllSymbols);
   else if (auto *Elf32BEObj = dyn_cast<ELF32BEObjectFile>(Obj))
     addDynamicElfSymbols(Elf32BEObj, AllSymbols);
-  else if (auto *Elf64BEObj = cast<ELF64BEObjectFile>(Obj))
+  else if (auto *Elf64BEObj = dyn_cast<ELF64BEObjectFile>(Obj))
     addDynamicElfSymbols(Elf64BEObj, AllSymbols);
   else
     llvm_unreachable("Unsupported binary format");


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54575.174192.patch
Type: text/x-patch
Size: 617 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181115/0a1ae042/attachment.bin>