[PATCH] D54154: [ELF][MIPS] Use MIPS R6 `sigrie` as a trap instruction

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Arch/Mips.cpp:61
+  // Set `sigrie 1` as a trap instruction.
+  write32(TrapInstr.data(), 0x04170001);
 
----------------
Let's not handle four byte sequence as one integer because it is very confusing. I'd write

  if (Config->IsLE)
    TrapInstr = {....};
  else
    TrapInstr = {....};


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D54154