[PATCH] D54543: [stack-safety] Inter-Procedural Analysis implementation

Mandeep Singh Grang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 14 14:37:41 PST 2018


mgrang added inline comments.


================
Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:494
+
+    std::sort(Callees.begin(), Callees.end());
+    Callees.erase(std::unique(Callees.begin(), Callees.end()), Callees.end());
----------------
Please use the range-based llvm::sort(Callees) instead of std::sort.

See https://llvm.org/docs/CodingStandards.html#beware-of-non-deterministic-sorting-order-of-equal-elements


Repository:
  rL LLVM

https://reviews.llvm.org/D54543





More information about the llvm-commits mailing list