[PATCH] D54469: Introduce new `disable_init` ASan option that is only supported on platforms where `SANITIZER_SUPPORTS_DISABLED_INIT` is true. Currently this is only supported on Darwin.

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 14 13:10:36 PST 2018


delcypher added inline comments.


================
Comment at: lib/asan/asan_internal.h:114
 
-// Add convenient macro for interface functions that may be represented as
-// weak hooks.
+#if SANITIZER_SUPPORTS_INIT_FOR_DLOPEN
+bool InitIsViaDlopen();
----------------
kcc wrote:
> please avoid introducing new ifdefs. There are plenty of them already, but no reason to make things worse. 
Okay. I will try to just declare these functions without the macro guards and just put stub implementations in each of the platform specific files.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D54469





More information about the llvm-commits mailing list