[PATCH] D54270: [ThinLTO] Update handling of vararg functions to match inliner

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 14 12:01:14 PST 2018


tejohnson added a comment.

In https://reviews.llvm.org/D54270#1298848, @efriedma wrote:

> This doesn't completely match what the inliner is doing.  We actually can inline functions that call va_start in some cases: specifically, we can inline in cases where we can prove the call to va_start is dead at a particular callsite.  Probably doesn't come up often enough to matter, though.


Thanks for the comment. I'm inclined to remove the vararg restrictions on importing altogether then. I had measured it without any restrictions for a large benchmark and it didn't have a significant impact on the import counts and binary size in any case.


Repository:
  rL LLVM

https://reviews.llvm.org/D54270





More information about the llvm-commits mailing list