[PATCH] D53190: ARM: avoid infinite combining loop

[Tim Northover via Phabricator via llvm-commits]

t.p.northover added a comment.

> Ok, fair point. If we are going to introduce a new node to fix this issue, could we have a SUBS node that can be glued to the CMOV?

I believe later passes already tidy things up enough that we don't need to embellish the DAG phase. For example if I compile:

  define i32 @foo(i32 %lhs, i32 %rhs, i32 %in) {
    %tst = icmp eq i32 %lhs, %rhs
    %res = select i1 %tst, i32 0, i32 %in
    ret i32 %res
  }

with this patch, I still get the optimum CodeGen of a single cmp and cmov.


Repository:
  rL LLVM

https://reviews.llvm.org/D53190