[PATCH] D53554: [Argument Promotion] Only promote args when function attributes are compatible

[Eric Christopher via Phabricator via llvm-commits]

echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

This looks better to me. I've got an inline request for some elaboration and you might want to let chandlerc comment, but otherwise OK with me.



================
Comment at: include/llvm/Analysis/TargetTransformInfo.h:933
 
+  /// \returns True if the caller and callee agree on the layout of \p Args.
+  /// \param[out] Args The list of compatible arguments.  The implementation may
----------------
"layout" is a bit difficult here, perhaps elaborate a bit?


Repository:
  rL LLVM

https://reviews.llvm.org/D53554