[PATCH] D54499: [codeview] Make "clang -g" emit codeview by default when targetting MSVC

[Reid Kleckner via Phabricator via llvm-commits]

rnk created this revision.
rnk added reviewers: smeenai, zturner.
Herald added subscribers: JDevlieghere, aprantl.

If you're using the Microsoft ABI, chances are that you want PDBs and
codeview debug info. Currently, everyone has to remember to specific
-gcodeview by default, when it would be nice if the standard -g option
did the right thing by default.

Also, do some related cleanup of -cc1 options. When targetting the MS
C++ ABI, we probably shouldn't pass -debugger-tuning=gdb. We were also
passing -gcodeview twice, which is silly.


https://reviews.llvm.org/D54499

Files:
  clang/include/clang/Basic/DebugInfoOptions.h
  clang/include/clang/Driver/ToolChain.h
  clang/lib/Driver/ToolChains/Clang.cpp
  clang/lib/Driver/ToolChains/MSVC.h
  clang/test/CodeGen/dwarf-version.c
  clang/test/CodeGenCXX/debug-info-byval.cpp
  clang/test/CodeGenCXX/debug-info-ctor2.cpp
  clang/test/CodeGenCXX/debug-info-member.cpp
  clang/test/CodeGenCXX/debug-info-method-spec.cpp
  clang/test/Driver/debug-options.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54499.173948.patch
Type: text/x-patch
Size: 11246 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181113/0d827035/attachment.bin>