[PATCH] D54359: [InstCombine] Remove a couple of asserts based on incorrect assumptions

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: Transforms/InstCombine/select-pr39595.ll:9
+; CHECK-NEXT: ret i32 [[TMP3:%.*]]
+; CHECK-DAG:  !0 = !{!"branch_weights", i32 1, i32 6}
+
----------------
I think the branch metadata is incorrect here. It should have been swapped. The original operands were "not %y for true" and "not %x" for false with the false case occuring more often meaning not %x is the most often case. Now the operands are %x for true and %y for false, but the branch metadata is the same so now it says %y occurs more often.


https://reviews.llvm.org/D54359