[PATCH] D53540: [COFF, ARM64] Implement support for SEH extensions __try/__except/__finally

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

Sorry, I didn't realize this was waiting on my review. It looks like this is mostly about localescape, so let's change the patch description and code to be about that.



================
Comment at: include/llvm/CodeGen/MachineFunction.h:332
   bool HasEHFunclets = false;
+  bool HasSEHFunclets = false;
 
----------------
IMO this should really live on the AArch64-specific function info, since it's not general to x64/x86 yet.

Also, this isn't SEH specific, this is set to true only by localescape. Maybe you should rename it? localescape was intended to be orthogonal to SEH, potentially usable for non-externally visible lambdas, although the codegen right now is particularly bad.


Repository:
  rL LLVM

https://reviews.llvm.org/D53540