[PATCH] D54481: [ELF] Rename NameTypeEntry::Type to CuIndexAndAttrs

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 13 10:39:10 PST 2018


MaskRay created this revision.
MaskRay added reviewers: ruiu, dblaikie.
Herald added subscribers: llvm-commits, arphaman, JDevlieghere, arichardson, aprantl, emaste.
Herald added a reviewer: espindola.

This value is a bit-packed value of CU index+attributes, which is named cu_index_and_attrs in a local variable in gdb/dwarf2read.c:dw2_symtab_iter_next


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D54481

Files:
  ELF/SyntheticSections.cpp
  ELF/SyntheticSections.h


Index: ELF/SyntheticSections.h
===================================================================
--- ELF/SyntheticSections.h
+++ ELF/SyntheticSections.h
@@ -683,7 +683,7 @@
 
   struct NameTypeEntry {
     llvm::CachedHashStringRef Name;
-    uint32_t Type;
+    uint32_t CuIndexAndAttrs;
   };
 
   struct GdbChunk {
Index: ELF/SyntheticSections.cpp
===================================================================
--- ELF/SyntheticSections.cpp
+++ ELF/SyntheticSections.cpp
@@ -2479,7 +2479,7 @@
         if ((ShardId & (Concurrency - 1)) != ThreadId)
           continue;
 
-        uint32_t V = Ent.Type + CuIdxs[I];
+        uint32_t V = Ent.CuIndexAndAttrs + CuIdxs[I];
         size_t &Idx = Map[ShardId][Ent.Name];
         if (Idx) {
           Symbols[ShardId][Idx - 1].CuVector.push_back(V);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54481.173881.patch
Type: text/x-patch
Size: 808 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181113/31190a0e/attachment.bin>


More information about the llvm-commits mailing list